-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Allow custom footer in password reset page #10461
Conversation
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10461 +/- ##
============================================
+ Coverage 15.99% 16.05% +0.06%
- Complexity 13080 13149 +69
============================================
Files 5649 5650 +1
Lines 495709 497688 +1979
Branches 60013 60652 +639
============================================
+ Hits 79268 79903 +635
- Misses 407594 408876 +1282
- Partials 8847 8909 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12568 |
[SF] Trillian test result (tid-12498)
|
two issues @vishesh92
|
@blueorangutan package |
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12640 |
@DaanHoogland try now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm,
tested in a lab env, bot loginFooter and resetPasswordFooter work.
@Pearl1594 can you have a look/merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally - lgtm.
Description
This PR allows setting a custom footer for resetPassword page in the UI.
Generated summary
This pull request includes updates to the login and reset password footer configurations in the UI. The changes ensure that the reset password footer is properly displayed when users are on the reset password page.
Changes to footer configurations:
ui/public/config.json
: Added a new configuration optionresetPasswordFooter
to the JSON file.ui/src/layouts/UserLayout.vue
: Updated the footer logic to display theresetPasswordFooter
when the user is on the reset password page, and to handle the presence of eitherloginFooter
orresetPasswordFooter
appropriately.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
user.password.reset.enabled
totrue
and restart MS./#/user/resetPassword
in the browser. IfresetPasswordFooter
is set, it will be displayed. If it is not set,loginFooter
is displayed.How did you try to break this feature and the system with this change?