Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allow custom footer in password reset page #10461

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Feb 25, 2025

Description

This PR allows setting a custom footer for resetPassword page in the UI.

Generated summary

This pull request includes updates to the login and reset password footer configurations in the UI. The changes ensure that the reset password footer is properly displayed when users are on the reset password page.

Changes to footer configurations:

  • ui/public/config.json: Added a new configuration option resetPasswordFooter to the JSON file.
  • ui/src/layouts/UserLayout.vue: Updated the footer logic to display the resetPasswordFooter when the user is on the reset password page, and to handle the presence of either loginFooter or resetPasswordFooter appropriately.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

  1. Enable user.password.reset.enabled to true and restart MS.
  2. Open /#/user/resetPassword in the browser. If resetPasswordFooter is set, it will be displayed. If it is not set, loginFooter is displayed.

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.05%. Comparing base (08ad1c7) to head (e1fbde1).
Report is 31 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10461      +/-   ##
============================================
+ Coverage     15.99%   16.05%   +0.06%     
- Complexity    13080    13149      +69     
============================================
  Files          5649     5650       +1     
  Lines        495709   497688    +1979     
  Branches      60013    60652     +639     
============================================
+ Hits          79268    79903     +635     
- Misses       407594   408876    +1282     
- Partials       8847     8909      +62     
Flag Coverage Δ
uitests 4.05% <ø> (+0.04%) ⬆️
unittests 16.89% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10461 (QA-JID-560)

@Pearl1594 Pearl1594 added this to the 4.20.1 milestone Feb 25, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12568

@blueorangutan
Copy link

[SF] Trillian test result (tid-12498)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53236 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10461-t12498-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 394.05 test_purge_expunged_vms.py

@DaanHoogland
Copy link
Contributor

two issues @vishesh92

  1. after setting loginFooter no contents is shown anymor. not even a login dialog. (also not after removing the value from config.json again
  2. no change is seen after setting resetPasswordFooter (maybe I am looking in the wrong place?)
    can you add some testing advice?

@vishesh92
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

sonarqubecloud bot commented Mar 3, 2025

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12640

@vishesh92
Copy link
Member Author

two issues @vishesh92

1. after setting `loginFooter` no contents is shown anymor. not even a login dialog. (also not after removing the value from config.json again

2. no change is seen after setting resetPasswordFooter (maybe I am looking in the wrong place?)
   can you add some testing advice?

@DaanHoogland try now.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm,
tested in a lab env, bot loginFooter and resetPasswordFooter work.

@DaanHoogland
Copy link
Contributor

@Pearl1594 can you have a look/merge?

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - lgtm.

@Pearl1594 Pearl1594 merged commit b8359e8 into 4.20 Mar 7, 2025
47 of 50 checks passed
@Pearl1594 Pearl1594 deleted the password-reset-allow-custom-footer branch March 7, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants