Improve Quota Statement #10506
Improve Quota Statement #10506
Conversation
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12669 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10506 +/- ##
============================================
+ Coverage 16.15% 16.27% +0.11%
- Complexity 13273 13400 +127
============================================
Files 5666 5680 +14
Lines 498081 499211 +1130
Branches 60267 60359 +92
============================================
+ Hits 80475 81251 +776
- Misses 408593 408923 +330
- Partials 9013 9037 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12689 |
…uotaServiceImplTest
|
I've just successfully builded the packages locally with |
|
@blueorangutan package |
|
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12742 |
| @Inject | ||
| private QuotaResponseBuilder _responseBuilder; | ||
| protected QuotaResponseBuilder responseBuilder; |
There was a problem hiding this comment.
default scope seems more apropriate for injected objects, Why is it protected?
There was a problem hiding this comment.
But the default scope is protected indeed... It's the same thing as not having the scope definition
There was a problem hiding this comment.
no, protected can go outside the package , default is package scope.
There was a problem hiding this comment.
meaning btw that default allows a test class in the same package to reach it, but not a child class from another package.
...atabase/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
Outdated
Show resolved
Hide resolved
Description
In the current version, the
quotaStatementAPI is returning the internal ID for account and domain, which is not useful for users, since all APIs use/return the UUID. Also, when theusage_typeparameter is informed, the API shows dummy records.To address those problems:
showresourceswas added to display more information to the user about each usage type;quotaStatementDetailsAPI was created to list more details about each usage type;Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
On CloudMonkey the
quotaStatementAPI was called and:usage_typeno dummy records were showed;showresourcesparameter is properly working;The
quotaStatementDetailsAPI was called successfully as well.