Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings resp, to systemvm agents #10524

Open
wants to merge 3 commits into
base: 4.20
Choose a base branch
from
Open

Fix to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings resp, to systemvm agents #10524

wants to merge 3 commits into from

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Mar 7, 2025 •
edited
Loading

Description

This PR fixes to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings respectively, to systemvm agents.

Noticed updated management servers list is not propagated to the system VMs during testing, it's regression from #9840.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Updated management servers list and lb algorithm in host andd indirect.agent.lb.algorithm settings, and checked in the system vm configuration file (/usr/local/cloud/systemvm/conf/agent.properties).

How did you try to break this feature and the system with this change?

@sureshanaparti
propagate updated management servers list and lb algorithm in host an…
ded089a 
…d indirect.agent.lb.algorithm settings, to systemvm agents
@sureshanaparti sureshanaparti added this to the 4.20.1 milestone Mar 7, 2025
@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti marked this pull request as ready for review March 7, 2025 09:29
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (8b09295) to head (7cdfaa9).
Report is 6 commits behind head on 4.20.

Files with missing lines Patch % Lines
...loudstack/agent/lb/IndirectAgentLBServiceImpl.java 4.16% 23 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              4.20   #10524       +/-   ##
============================================
+ Coverage     4.00%   16.00%   +12.00%     
- Complexity       0    13104    +13104     
============================================
  Files          397     5651     +5254     
  Lines        32487   495858   +463371     
  Branches      5760    60046    +54286     
============================================
+ Hits          1301    79371    +78070     
- Misses       31037   407627   +376590     
- Partials       149     8860     +8711
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.84% <4.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti changed the title Fix to propagate updated management servers list and lb algorithm in host andd indirect.agent.lb.algorithm settings, to systemvm agents Fix to propagate updated management servers list and lb algorithm in host and indirect.agent.lb.algorithm settings resp, to systemvm agents Mar 7, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12698

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12704

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12626)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12625)

shwstppr
shwstppr reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti thanks for the fix. Left a couple of comments

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@sureshanaparti sureshanaparti requested a review from shwstppr March 10, 2025 09:21
@sureshanaparti sureshanaparti requested a review from shwstppr March 10, 2025 11:02
shwstppr
shwstppr approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12722

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12627)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 65954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12627-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 343.95 test_events_resource.py
test_01_events_resource Error 343.96 test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 117.37 test_network_permissions.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1524.84 test_network.py
test_02_restore_vm_with_disk_offering Error 58.30 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 58.31 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 61.62 test_vm_strict_host_tags.py

@Pearl1594
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12728

@blueorangutan
Copy link

[SF] Trillian test result (tid-12628)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 79447 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12628-xcpng82.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 170.22 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 177.34 test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 30.06 test_network.py
test_01_non_strict_host_anti_affinity Error 236.47 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 122.58 test_nonstrict_affinity_group.py
test_02_create_volume Error 2.21 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 72.73 test_scale_vm.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12636)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57012 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10524-t12636-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1519.45 test_network.py

DaanHoogland
DaanHoogland approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti force-pushed the propagate-ms-list-to-systemvms branch from c6c21ac to 7cdfaa9 Compare March 11, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees
No one assigned
Labels
type:regression
Projects
None yet
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.
5 participants
@sureshanaparti @blueorangutan @DaanHoogland @shwstppr @Pearl1594