Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Hide User Card from config.userCard.enabled option #10545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OlegChuev
Copy link
Contributor

Description

This PR makes the User Card toggleable via config.json, which is particularly useful when users shouldn’t be aware of API docs or other information.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

With "enabled": true and when enabled absent from the config.json
image

With "enabled": false:

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Mar 12, 2025
@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.26%. Comparing base (b387bc1) to head (4632795).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10545   +/-   ##
=========================================
  Coverage     16.26%   16.26%           
  Complexity    13389    13389           
=========================================
  Files          5674     5674           
  Lines        498927   498927           
  Branches      60337    60337           
=========================================
+ Hits          81157    81159    +2     
+ Misses       408729   408728    -1     
+ Partials       9041     9040    -1     
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 17.12% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10545 (QA-JID-576)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants