Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui,server: add s390x architecture selection #10556

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

shwstppr
Copy link
Contributor

Description

Based on changes from #10289

s390x support was added paritally with #10038

Will rebase once #10289 is merged

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Check plan for a created instance so retry can be done if it fails for a
particular template

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
New zone-scope config added system.vm.preferred.architecture to allow deployment using specific architecture for system VMs including VRs.
Refactor and added checks for deployements

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Based on changes from apache#10289

s390x support was added paritally with apache#10038

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 5.21327% with 600 lines in your changes missing coverage. Please review.

Project coverage is 16.26%. Comparing base (9c6f2a9) to head (b0cf095).

Files with missing lines Patch % Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java 0.00% 190 Missing ⚠️
.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java 1.53% 64 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java 0.00% 62 Missing ⚠️
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 56 Missing ⚠️
...va/com/cloud/network/router/NetworkHelperImpl.java 0.00% 49 Missing ⚠️
utils/src/main/java/com/cloud/utils/HttpUtils.java 0.00% 36 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 35 Missing ⚠️
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java 0.00% 14 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 14 Missing ⚠️
...src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java 0.00% 11 Missing ⚠️
... and 18 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10556      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13388    13387       -1     
============================================
  Files          5674     5674              
  Lines        498929   499266     +337     
  Branches      60338    60381      +43     
============================================
+ Hits          81154    81182      +28     
- Misses       408736   409042     +306     
- Partials       9039     9042       +3     
Flag Coverage Δ
uitests 3.99% <ø> (+<0.01%) ⬆️
unittests 17.11% <5.21%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant