Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: Upgrade gson version to 2.10.1 #8756

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 7, 2024

Description

This PR upgrades gson from 1.7.2 to 2.10.1

gson versions are listed at https://mvnrepository.com/artifact/com.google.code.gson/gson

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.22%. Comparing base (48f890a) to head (e86f751).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
.../api/response/ClusterDrsPlanMigrationResponse.java 0.00% 2 Missing ⚠️
...va/com/cloud/agent/transport/ArrayTypeAdaptor.java 71.42% 2 Missing ⚠️
.../apache/cloudstack/metrics/MetricsServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8756      +/-   ##
============================================
+ Coverage     16.15%   16.22%   +0.07%     
- Complexity    13267    13330      +63     
============================================
  Files          5666     5666              
  Lines        498051   499673    +1622     
  Branches      60259    60794     +535     
============================================
+ Hits          80454    81086     +632     
- Misses       408589   409522     +933     
- Partials       9008     9065      +57     
Flag Coverage Δ
uitests 4.05% <ø> (+0.04%) ⬆️
unittests 17.07% <61.53%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8875

@vishesh92
Copy link
Member

RequestTest & LogUtilsTest are failing. (Other tests might be failing as well. haven't checked).
We will need to go through the release notes and ensure that we don't break anything.
https://github.com/google/gson/blob/main/CHANGELOG.md

@weizhouapache
Copy link
Member Author

RequestTest & LogUtilsTest are failing. (Other tests might be failing as well. haven't checked). We will need to go through the release notes and ensure that we don't break anything. https://github.com/google/gson/blob/main/CHANGELOG.md

yes @vishesh92
I marked it as draft . I will revisit it later.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8925

@weizhouapache weizhouapache changed the base branch from 4.19 to main March 13, 2024 21:38
@weizhouapache
Copy link
Member Author

now the only issue with simulator CI is caused by
Execute cmd: generateclusterdrsplan failed, due to: errorCode: 431, errorText:Class org.apache.cloudstack.api.response.ClusterDrsPlanMigrationResponse declares multiple JSON fields named 'jobid'; conflict is caused by fields org.apache.cloudstack.api.response.ClusterDrsPlanMigrationResponse#jobId and org.apache.cloudstack.api.BaseResponse#jobId"

@SerializedName(ApiConstants.JOB_ID)
@Param(description = "the UUID of the latest async job acting on this object")
protected String jobId;
@SerializedName(ApiConstants.JOB_STATUS)
@Param(description = "the current status of the latest async job acting on this object")
private Integer jobStatus;

@SerializedName(ApiConstants.JOB_ID)
@Param(description = "id of VM migration async job")
private Long jobId;
@SerializedName(ApiConstants.JOB_STATUS)
@Param(description = "Job status of VM migration async job")
private JobInfo.Status jobStatus;

the two files have same name jobId and jobStatus but different type.

@vishesh92

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9004

@weizhouapache
Copy link
Member Author

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9557)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 56215 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t9557-kvm-rocky8.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Error 124.67 test_cluster_drs.py
test_02_balanced_drs_algorithm Error 122.03 test_cluster_drs.py
test_01_redundant_vpc_site2site_vpn Failure 706.42 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 585.03 test_vpc_vpn.py

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9016

@weizhouapache
Copy link
Member Author

@blueorangutan test rocky8 kvm-rocky8

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-9563)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 58266 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t9563-kvm-rocky8.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 100.33 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 55.93 test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn Failure 680.88 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 354.70 test_vpc_vpn.py

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9561

@blueorangutan
Copy link

[SF] Trillian test result (tid-12417)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 55149 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12417-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_multiple_mgmt_server_ownership Failure 30.77 test_outofbandmanagement.py
test_06_purge_expunged_vm_background_task Failure 388.71 test_purge_expunged_vms.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12416)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12416-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 385.36 test_purge_expunged_vms.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12420)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63806 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12420-vmware-70u3.zip
Smoke tests completed. 130 look OK, 11 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 341.36 test_events_resource.py
test_04_deploy_vm_with_extraconfig_throws_exception_vmware Error 4.49 test_deploy_vm_extra_config_data.py
test_deploy_more_vms_than_limit_allows Error 165.21 test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_01_prepare_and_cancel_maintenance Error 0.08 test_ms_maintenance_and_safe_shutdown.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 123.59 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 156.38 test_network.py
test_06_purge_expunged_vm_background_task Failure 393.74 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 66.18 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 58.00 test_restore_vm.py
test_14_destroy_vm_delete_protection Error 10.64 test_vm_life_cycle.py
test_02_restore_vm_strict_tags_failure Error 63.72 test_vm_strict_host_tags.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12419)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 76556 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12419-xcpng82.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 199.24 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 190.51 test_cluster_drs.py
test_01_prepare_and_cancel_maintenance Error 0.10 test_ms_maintenance_and_safe_shutdown.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 8.40 test_network.py
test_01_non_strict_host_anti_affinity Error 218.47 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 122.32 test_nonstrict_affinity_group.py
test_06_purge_expunged_vm_background_task Failure 395.44 test_purge_expunged_vms.py
test_02_create_volume Error 2.23 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 70.43 test_scale_vm.py
test_02_cancel_host_maintenace_with_migration_jobs Error 2386.39 test_host_maintenance.py

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12435)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12436)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12437)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12438)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12440)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12441)

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@weizhouapache
Copy link
Member Author

[SF] Trillian test result (tid-12420) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63806 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12420-vmware-70u3.zip Smoke tests completed. 130 look OK, 11 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 341.36 test_events_resource.py
test_04_deploy_vm_with_extraconfig_throws_exception_vmware Error 4.49 test_deploy_vm_extra_config_data.py
test_deploy_more_vms_than_limit_allows Error 165.21 test_deploy_vms_in_parallel.py
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_01_prepare_and_cancel_maintenance Error 0.08 test_ms_maintenance_and_safe_shutdown.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 123.59 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 156.38 test_network.py
test_06_purge_expunged_vm_background_task Failure 393.74 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 66.18 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 58.00 test_restore_vm.py
test_14_destroy_vm_delete_protection Error 10.64 test_vm_life_cycle.py
test_02_restore_vm_strict_tags_failure Error 63.72 test_vm_strict_host_tags.py

these failures are almost same as 4.21 health check
#10149 (comment)

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12610

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs testing, otherwise LGTM

@weizhouapache
Copy link
Member Author

thanks guys for approvals

currently there are some smoke test failures with 4.20/main.
let's stablize the branches and merge this PR, otherwise we do not know whether the failures are caused by this PR or not.

@blueorangutan
Copy link

[SF] Trillian test result (tid-12512)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 56516 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12512-kvm-ubuntu22.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_multiple_mgmt_server_ownership Failure 31.84 test_outofbandmanagement.py
test_06_purge_expunged_vm_background_task Failure 390.67 test_purge_expunged_vms.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12511)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12511-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_06_purge_expunged_vm_background_task Failure 390.17 test_purge_expunged_vms.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12513)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 61116 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12513-vmware-70u3.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 341.88 test_events_resource.py
test_01_prepare_and_cancel_maintenance Error 0.09 test_ms_maintenance_and_safe_shutdown.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 131.65 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 166.47 test_network.py
test_06_purge_expunged_vm_background_task Failure 400.62 test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering Error 56.08 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 66.38 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 53.35 test_vm_strict_host_tags.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-12514)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 81900 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12514-xcpng82.zip
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 171.78 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 177.77 test_cluster_drs.py
test_01_prepare_and_cancel_maintenance Error 0.10 test_ms_maintenance_and_safe_shutdown.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 7.53 test_network.py
test_01_non_strict_host_anti_affinity Error 270.44 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 114.37 test_nonstrict_affinity_group.py
test_06_purge_expunged_vm_background_task Failure 415.20 test_purge_expunged_vms.py
test_02_create_volume Error 2.24 test_resource_names.py
test_05_scale_vm_dont_allow_disk_offering_change Failure 74.92 test_scale_vm.py
test_01_volume_usage Error 98.09 test_usage.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants