Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bnr resource limits #9765

Closed
wants to merge 18 commits into from
Closed

Bnr resource limits #9765

wants to merge 18 commits into from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR addresses:

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 234 lines in your changes missing coverage. Please review.

Project coverage is 15.77%. Comparing base (046870e) to head (6646d63).
Report is 249 commits behind head on main.

Files with missing lines Patch % Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java 0.00% 79 Missing ⚠️
...main/java/org/apache/cloudstack/backup/Backup.java 0.00% 15 Missing ⚠️
...rg/apache/cloudstack/backup/dao/BackupDaoImpl.java 0.00% 12 Missing ⚠️
...main/java/com/cloud/api/query/vo/DomainJoinVO.java 0.00% 12 Missing ⚠️
...bernetes/cluster/KubernetesClusterManagerImpl.java 0.00% 10 Missing ⚠️
...pache/cloudstack/api/response/AccountResponse.java 0.00% 9 Missing ⚠️
...apache/cloudstack/api/response/DomainResponse.java 0.00% 9 Missing ⚠️
...pache/cloudstack/api/response/ProjectResponse.java 0.00% 9 Missing ⚠️
...rg/apache/cloudstack/backup/NASBackupProvider.java 0.00% 8 Missing ⚠️
...org/apache/cloudstack/backup/BackupScheduleVO.java 0.00% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9765      +/-   ##
============================================
- Coverage     15.78%   15.77%   -0.02%     
  Complexity    12552    12552              
============================================
  Files          5625     5625              
  Lines        491972   492423     +451     
  Branches      63764    59970    -3794     
============================================
+ Hits          77664    77683      +19     
- Misses       405849   406280     +431     
- Partials       8459     8460       +1     
Flag Coverage Δ
uitests 4.03% <ø> (-0.01%) ⬇️
unittests 16.59% <3.70%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1.6% Coverage on New Code (required ≥ 40%)
21.3% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

github-actions bot commented Jan 8, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@rohityadavcloud
Copy link
Member

@Pearl1594 @abh1sar @rajujith can your review and advise if the other PR has already addressed this?

@Pearl1594 Pearl1594 closed this Feb 11, 2025
@DaanHoogland DaanHoogland deleted the bnr-resource-limits branch February 12, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants