Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(android): Improve documentation of onRequestPermissionResult #1400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitToTheHub
Copy link
Contributor

@GitToTheHub GitToTheHub commented Feb 15, 2025

Platforms affected

Android

Motivation and Context

It was not documented, that grantResults can be empty when the permissions request interaction with the user was interrupted and that onRequestPermissionResult is a method from Android.

  • Mention that it is a forwarded Android method
  • Add Android documentation link for onRequestPermissionsResult
  • Handle and document grandResult.length == 0, which can occur, if the request interaction was interrupted
  • Document code in onRequestPermissionResult and small refactoring

I changed this in dev, 12.x-2025.01, 12.x, 11.x

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Mention that it is a forwarded Android method
- Add Android documentation link for onRequestPermissionsResult
- Handle and document grandResult.length == 0, which can occur, if the request interaction was interrupted
- Document code in onRequestPermissionResult and small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant