-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(clouseau
): bump to 2.25.0
#5488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We have had a couple of new Clouseau releases in the past few months. So catch up with them and use the latest version as both the default for the `configure` script and implicitly for the CI.
Hey Gábor, to run the full CI, you need a branch name starting with |
Yes, you are right. That is my plan forward, but first I wanted to make sure that it passes the basic tests. |
I see this for Windows:
Could this be an issue specific to the Windows builder? |
Is it possible that Clouseau isn't loaded at this stage, so that the "ping" failed? How does Clouseau gets startet? We only have |
I am not sure about that. To me, the error message above suggests that
I believe that should be sufficient. This is out of my concern at the moment. |
Fixing the CI for the FreeBSD, macOS, and Windows workers is getting more complicated. I will just drop those commits from the PR so we could just safely merge the bump itself. |
6e0e710
to
5d357e2
Compare
We have had a couple of new Clouseau releases in the past few months. So catch up with them and use the latest version as both the default for the
configure
script and implicitly for the CI.Testing recommendations
Other than exercising the change in the CI, one could manually verify it. Configure with Clouseau enabled (UNIX-like systems, including macOS) and be sure to have Java 8 on the path:
or on Windows:
.\configure.ps1 -WithClouseau
Note that you may have to remove any older local installation of Clouseau before proceeding:
Run the Mango tests (implies using Clouseau):
Note that there shall be only a single skipped test in this scenario. Anything more than that may signal that Clouseau has not been fully configured.
Run the Elixir search tests (implies using Clouseau):
This should all work with Erlang/OTP 25, 26, and 27.
To verify if logging is still working, you can take a look at the contents of the
dev/logs/clouseau1.log
file after Clouseau has been started up alongside CouchDB, e.g.:Checklist