Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Benchmark deps cleanup #14793

Merged
merged 3 commits into from
Feb 21, 2025
Merged

chore: Benchmark deps cleanup #14793

merged 3 commits into from
Feb 21, 2025

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 20, 2025

No description provided.

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates core Core DataFusion crate functions Changes to functions implementation labels Feb 20, 2025
Use same version everywhere. This means update for some crates.
Use same version everywhere and update.
Get the char in O(1) instead of O(n).
@findepi findepi changed the title Benchmark deps cleanup chore: Benchmark deps cleanup Feb 21, 2025
@findepi findepi merged commit 2325b6c into apache:main Feb 21, 2025
26 checks passed
@findepi findepi deleted the findepi/deps branch February 21, 2025 08:52
ozankabak pushed a commit to synnada-ai/datafusion-upstream that referenced this pull request Feb 25, 2025
* Synchronize criterion version across workspace

Use same version everywhere. This means update for some crates.

* Synchronize and update rand version across workspace

Use same version everywhere and update.

* Avoid linear search for character in bench helper

Get the char in O(1) instead of O(n).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate functions Changes to functions implementation physical-expr Changes to the physical-expr crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants