Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: comment in Cargo.toml about MSRV #14809

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Minor: comment in Cargo.toml about MSRV #14809

merged 2 commits into from
Feb 22, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 21, 2025

Which issue does this PR close?

Rationale for this change

  • I wasn't able to quickly find where the MSRV was defined when filing Upgrade to Rust 1.85 #14808 so I would like to make it easier to find nex time

What changes are included in this PR?

Add some comments

Are these changes tested?

Are there any user-facing changes?

- I wasn't able to quickly find where the MSRV was defined when filing  #14808 so I would like to make it easier to find nex time
@alamb alamb marked this pull request as ready for review February 21, 2025 11:24
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit 0bd9083 into main Feb 22, 2025
50 checks passed
ozankabak pushed a commit to synnada-ai/datafusion-upstream that referenced this pull request Feb 25, 2025
- I wasn't able to quickly find where the MSRV was defined when filing  apache#14808 so I would like to make it easier to find nex time
@alamb alamb deleted the alamb-patch-2 branch March 1, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants