-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use TypeSignature::Coercible for crypto functions #14826
base: main
Are you sure you want to change the base?
Conversation
3cb1d36
to
2dcee88
Compare
Hi @jayzhan211, I encountered some CI failures in the [SQL] EXPLAIN SELECT
digest(column1_utf8view, 'md5') as c
FROM test;
[Diff] (-expected|+actual)
logical_plan
- 01)Projection: digest(test.column1_utf8view, Utf8View("md5")) AS c
+ 01)Projection: digest(test.column1_utf8view, Utf8("md5")) AS c
02)--TableScan: test projection=[column1_utf8view] Should we:
I'm not sure which one is better, could you give me some suggestions or other best practices? thanks very much!! |
This looks like an improvement, we don't need to cast it to utf8view |
CI appears to be failing, so marking this one as a draft |
d3efb81
to
03b40f4
Compare
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?