Minor: Add indentation to EnforceDistribution test plans. #15007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
alamb
changed the title
alamb
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thank you very much @wiedld
I think this PR is a major improvement as now we can actually see the structure of the plans in the expected output as it is encoded by whitespace
I'll plan to merge this PR tomorrow unless anyone would like more time to review
| "RepartitionExec: partitioning=Hash([c@2], 10), input_partitions=10", | ||
| "RepartitionExec: partitioning=RoundRobinBatch(10), input_partitions=1", | ||
| "DataSourceExec: file_groups={1 group: [[x]]}, projection=[a, b, c, d, e], file_type=parquet", | ||
| &join_plan_indent2, |
wiedld
changed the title
danila-b
pushed a commit
to danila-b/datafusion
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Make it easier to skim test case plans.
What changes are included in this PR?
Only changes the plans used in the test cases; change to include indentation.
Are these changes tested?
Yes
Are there any user-facing changes?
No