Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency checks to verify-release-candidate script #15009

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Mar 4, 2025

Which issue does this PR close?

  • Closes #.

Rationale for this change

Check all build dependencies are available before running the script.

Background: I'll use a separate docker to verify the release candidate. And I always forget to install some of the build dependencies. Then I need to install it and restart from the very beginning. I list all the things I'm aware of (or need to be installed in a fresh ubuntu image) and check them before the build starts.

What changes are included in this PR?

A new function check_dependencies in dev/release/verify-release-candidate.sh that checks build dependencies in advance.

Are these changes tested?

Yes, I use this version to verify 46.0.0 RC2 release

Are there any user-facing changes?

no

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 4, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waynexia

I ran this script on my machine for a 46.0.0 RC and it seems to have worked well.

andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ ./dev/release/verify-release-candidate.sh 46.0.0 1
+ set -o pipefail
+ check_dependencies
+ local missing_deps=0
+ required_deps=("curl" "git" "gpg" "cc" "protoc")
+ local required_deps
+ local has_sha_tools=0
+ for dep in '"${required_deps[@]}"'
+ command -v curl
+ for dep in '"${required_deps[@]}"'
+ command -v git
+ for dep in '"${required_deps[@]}"'
+ command -v gpg
+ for dep in '"${required_deps[@]}"'
+ command -v cc
+ for dep in '"${required_deps[@]}"'
+ command -v protoc
+ command -v shasum
+ has_sha_tools=1
+ '[' 0 -ne 0 ']'
+++ dirname ./dev/release/verify-release-candidate.sh
++ cd ./dev/release
++ pwd
+ SOURCE_DIR=/Users/andrewlamb/Software/datafusion/dev/release
+++ dirname /Users/andrewlamb/Software/datafusion/dev/release
++ dirname /Users/andrewlamb/Software/datafusion/dev
+ ARROW_DIR=/Users/andrewlamb/Software/datafusion
+ ARROW_DIST_URL=https://dist.apache.org/repos/dist/dev/datafusion
+ type shasum
+ sha256_verify='shasum -a 256 -c'
+ sha512_verify='shasum -a 512 -c'
+ TEST_SUCCESS=no
+ setup_tempdir datafusion-46.0.0
+ '[' -z '' ']'
++ mktemp -d -t datafusion-46.0.0.XXXXX
...

@waynexia waynexia merged commit dfb711f into apache:main Mar 5, 2025
24 checks passed
@waynexia
Copy link
Member Author

waynexia commented Mar 5, 2025

Thank you @alamb

danila-b pushed a commit to danila-b/datafusion that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants