Minor: Deprecate ScalarValue::raw_data
#15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Mar 5, 2025
| @@ -2764,15 +2764,6 @@ impl ScalarValue { | |||
| Ok(scalars) | |||
| } | |||
|
|
|||
| // TODO: Support more types after other ScalarValue is wrapped with ArrayRef | |||
| /// Get raw data (inner array) inside ScalarValue | |||
| pub fn raw_data(&self) -> Result<ArrayRef> { | |||
There was a problem hiding this comment.
Thank you very much @qazxcdswe123 -- this is a nice find.
Per https://datafusion.apache.org/contributor-guide/api-health.html instead of removing this function, can you please mark it as #[deprecated] instead?
Maybe it would be a good time to go remove any deprecated functions from 41 or earlier 🤔
There was a problem hiding this comment.
Thanks for the remind!
And I think to_array is what we meant to do here?
datafusion/datafusion/common/src/scalar/mod.rs
Line 1766 in c0d53ad
There was a problem hiding this comment.
I'll file another PR to cleanup some old deprecation
qazxcdswe123
force-pushed
the
cleanup
branch
2 times, most recently
from
b35e856 to
2fcc908
Compare
alamb
changed the title
ScalarValue::raw_data
danila-b
pushed a commit
to danila-b/datafusion
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
cleanup unused deadcode
What changes are included in this PR?
cleanup unused deadcode
Are these changes tested?
yes
Are there any user-facing changes?
noI just realized this is a
pub fnso if anyone is using this they may be affected. But this function does not seem to be useful?