fix: mark ScalarUDFImpl::invoke_batch as deprecated #15049
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
See #14123 (comment)
Rationale for this change
People should use
invoke_with_argsinstead. Callinginvoke_batchfor any DF-builtin function will fail at runtime with something likeFunction X does not implement invoke but calledWe should also consider just removing the old functions (invoke_batch, invoke, invoke_no_args), to clear up the trait.
What changes are included in this PR?
Mark
invoke_batchas deprecated. It was already called so in the docstring, but the compiler doesn't read those.Are these changes tested?
Existing tests
Are there any user-facing changes?
New deprecation