Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering extended tests through PR comment #15101

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

danila-b
Copy link

@danila-b danila-b commented Mar 8, 2025

Which issue does this PR close?

Closes #14319

Rationale for this change

Allows to run extended tests on some PRs if needed, while skipping them by default on other PRs. The user experience of running the extended test suite should be roughly the same (check is shown in the PR actions tab, comment is marked with 🚀 emoji when the tests are triggered for the PR)

What changes are included in this PR?

Adding a new trigger event for extended tests - workflow_dispatch, and a separate action which is checking all PR comments and issuing this dispatch event for the PR branch when the Run extended tests comment is detected.

Are these changes tested?

Only manual tests on the fork (see here), unfortunately I am not aware of any better tests for Github actions.

image

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 8, 2025
@Omega359
Copy link
Contributor

Omega359 commented Mar 8, 2025

Looks like it ran checks on the forked branch, I think that is what we want

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to trigger the extended test suite from a PR
2 participants