uint32_t weight in tdigest<float> + cross-language test #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8056069290Details
💛 - Coveralls |
AlexanderSaydakov
changed the title
jmalkin
requested changes
Feb 26, 2024
tdigest/include/tdigest.hpp
Outdated
| void add(const centroid& other) { | ||
| weight_ += other.weight_; | ||
| mean_ += (other.mean_ - mean_) * other.weight_ / weight_; | ||
| } | ||
| T get_mean() const { return mean_; } | ||
| uint64_t get_weight() const { return weight_; } | ||
| T get_weight() const { return weight_; } |
tdigest/test/tdigest_test.cpp
Outdated
| REQUIRE(bytes.size() == static_cast<size_t>(s.tellg())); | ||
|
|
||
| REQUIRE(deserialized_td1.get_k() == deserialized_td2.get_k()); | ||
| REQUIRE(deserialized_td1.get_total_weight() == deserialized_td2.get_total_weight()); |
There was a problem hiding this comment.
This never actually checks that the weight is 0 or that is_empty() returns true, only that they're equivalent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate files for Java