Get serialized size

[AlexanderSaydakov]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 9037130030

Details

• 26 of 26 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.962%

---

Totals
Change from base Build 8399205905:	0.0%
Covered Lines:	16404
Relevant Lines:	16576

---

💛 - Coveralls

[jmalkin]

The new test is a little strange to me but not unreasonable. Seems inefficient but I guess that's ok.

[AlexanderSaydakov]

Perhaps I could explain in the test. The sketch reaches capacity for the first time at 2 * K * 15/16, but at that point it is still in exact mode, so the serialized size is not the maximum (theta in not needed in the exact mode). So we need to catch the second time, but some updates will be ignored in the estimation mode, so I updated more than enough times keeping track of the maximum. Perhaps I should have figured out the exact number of updates given this particular sequence, but not assuming that might be even better (say, in case we change the load factor or just out of principle not to rely on implementation details too much).

[jmalkin]

Yeah, the test is fine. It just feels sort of overkill to serialize after every update just to check. Not quite an ideal design for quick tests but with lgK=10 it should be ok in practice.