refactor(cli): Improve CLI commands with better error handling and output formatting #19114
justinmcleanAnnotations
6 errors and 1 warning
|
build (17):
task ':clients:cli:spotlessJavaCheck'#L1
Execution failed for task ':clients:cli:spotlessJavaCheck':
The following files had format violations:
src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java
@@ -64,4 +64,4 @@
······displayAuditInfo(result.auditInfo());
····}
··}
-}
+}
src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java
@@ -53,7 +53,7 @@
······Catalog·gCatalog·=·client.loadCatalog(catalog);
······if·(gCatalog·!=·null)·{
-··········printProperties(gCatalog.properties());
+········printProperties(gCatalog.properties());
······}
····}·catch·(NoSuchMetalakeException·err)·{
······exitWithError(ErrorMessages.UNKNOWN_METALAKE);
src/main/java/org/apache/gravitino/cli/commands/ListColumns.java
@@ -18,12 +18,12 @@
·*/
package·org.apache.gravitino.cli.commands;
+import·com.google.common.base.Joiner;
import·org.apache.gravitino.NameIdentifier;
import·org.apache.gravitino.cli.CommandContext;
import·org.apache.gravitino.cli.ErrorMessages;
import·org.apache.gravitino.exceptions.NoSuchTableException;
import·org.apache.gravitino.rel.Column;
-import·com.google.common.base.Joiner;
/**·Displays·the·details·of·a·table's·columns.·*/
public·class·ListColumns·extends·TableCommand·{
@@ -47,57 +47,62 @@
····this.table·=·table;
··}
-····/**·Displays·the·details·of·a·table's·columns.·*/··
-····@OverRide
-····public·void·handle()·{
-········try·{
-············NameIdentifier·name·=·NameIdentifier.of(schema,·table);
-············Column[]·columns·=·tableCatalog().loadTable(name).columns();
+··/**·Displays·the·details·of·a·table's·columns.·*/
+··@OverRide
+··public·void·handle()·{
+····try·{
+······NameIdentifier·name·=·NameIdentifier.of(schema,·table);
+······Column[]·columns·=·tableCatalog().loadTable(name).columns();
-············if·(columns·!=·null·&&·columns.length·>·0)·{
... (89 more lines that didn't fit)
Violations also present in:
src/main/java/org/apache/gravitino/cli/commands/ListFilesetProperties.java
src/main/java/org/apache/gravitino/cli/commands/ListMetalakeProperties.java
src/main/java/org/apache/gravitino/cli/commands/ListSchemaProperties.java
Run './gradlew :clients:cli:spotlessApply' to fix these violations.
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:111)
at com.diffplug.gradle.spotless.SpotlessCheck.performAction(SpotlessCheck.java:53)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29)
at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:248)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
at org.gradle.internal.
|
|
build (17)
Process completed with exit code 1.
|
|
build (8)
The job was canceled because "_17" failed.
|
|
build (8)
The operation was canceled.
|
|
build (11)
The job was canceled because "_17" failed.
|
|
build (11)
The operation was canceled.
|
|
build (17)
No files were found with the provided path: build/reports
catalogs/**/*.log
catalogs/**/*.tar. No artifacts will be uploaded.
|