[#5744]feat(catalog-model): Add a basic catalog-model framework in Gravitino #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Dec 4, 2024
...s/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalogCapability.java
Outdated
Show resolved
Hide resolved
catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalog.java
Show resolved
Hide resolved
mchades
reviewed
Dec 5, 2024
yuqi1129
reviewed
Dec 5, 2024
| * catalog should be created. The short name: | ||
| * | ||
| * <p>1) should be the same as the {@link CatalogProvider} interface provided. 2) can be "null" if | ||
| * the created catalog is a built-in catalog, like model catalog. |
There was a problem hiding this comment.
I'm very puzzle about the concept of built-in catalog, can you explain it more clearly.
There was a problem hiding this comment.
And, so the provider of all built-in catalogs is null?
There was a problem hiding this comment.
Let me add more comment to explain the concept introduced here.
There was a problem hiding this comment.
From the user level, the "provider" value can be null, user doesn't need to provide the "provider" for those catalogs.
From the Gravitino kernel, it will treat the catalog "type" name as the "provider" name, and use this name to load in the catalog.
common/src/main/java/org/apache/gravitino/dto/requests/CatalogCreateRequest.java
Outdated
Show resolved
Hide resolved
yuqi1129
approved these changes
Dec 9, 2024
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Dec 13, 2024
… in Gravitino (apache#5757) ### What changes were proposed in this pull request? This PR adds the basic catalog-model framework in Gravitino. In the meantime, it also makes `provider` optional for built-in catalog. ### Why are the changes needed? Fix: apache#5744 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tests will be added later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the basic catalog-model framework in Gravitino. In the meantime, it also makes
provideroptional for built-in catalog.Why are the changes needed?
Fix: #5744
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tests will be added later on.