[#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout #5835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Dec 11, 2024
| /// the `file_id` and `parent_file_id` it is the unique identifier for the file system, it is used to identify the file or directory | ||
| /// the `fh` it is the file handle, it is used to identify the opened file, it is used to read or write the file content | ||
| #[async_trait] | ||
| pub(crate) trait RawFileSystem: Send + Sync { |
There was a problem hiding this comment.
The name of RawFileSystem is confusing, could you provide better name?
There was a problem hiding this comment.
I think the name is OK, Could you have a good suggestion.
| }) | ||
| } | ||
|
|
||
| async fn destroy(&self, _req: Request) {} |
There was a problem hiding this comment.
why not release the resource in local_fs here?
There was a problem hiding this comment.
That's not implemented yet.
|
How do you pass user information to Gravitino? |
This pr is not touch |
diqiu50
force-pushed
the
gvfs-pr1
branch
3 times, most recently
from
f59eb23 to
515a2d8
Compare
FANNG1
reviewed
Dec 12, 2024
FANNG1
reviewed
Dec 12, 2024
FANNG1
reviewed
Dec 12, 2024
FANNG1
reviewed
Dec 12, 2024
FANNG1
reviewed
Dec 13, 2024
| pub(crate) ctime: Timestamp, | ||
|
|
||
| // file link count | ||
| pub(crate) nlink: u32, |
There was a problem hiding this comment.
That's a reference count of the file. we may use it later.
There was a problem hiding this comment.
Could you provide an example about how to use it ?
There was a problem hiding this comment.
This can be considered in a later PR. Let's first push the framework so others can join in.
|
LGTM, except minor comments |
diqiu50
force-pushed
the
gvfs-pr1
branch
2 times, most recently
from
d15fd9d to
96d442c
Compare
diqiu50
force-pushed
the
gvfs-pr1
branch
2 times, most recently
from
83436a4 to
a423492
Compare
FANNG1
reviewed
Dec 14, 2024
| async fn create_file(&self, parent_file_id: u64, name: &str, flags: u32) -> Result<FileHandle>; | ||
|
|
||
| /// Create the directory by parent file id and file name | ||
| /// Create the directory by parent file id and file name, if successful, return the file id |
There was a problem hiding this comment.
How about defining a new type FileID not using u64 directly here?
There was a problem hiding this comment.
use u64 is ok. It shouldn't be necessary.
FANNG1
reviewed
Dec 14, 2024
FANNG1
approved these changes
Dec 16, 2024
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…tion and code structure layout (apache#5835) ### What changes were proposed in this pull request? 1. Implement basic FUSE interfaces. 2. Implement filesystem trait and relation structures. ### Why are the changes needed? Fix: apache#5734 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jan 3, 2025
…tion and code structure layout (apache#5835) ### What changes were proposed in this pull request? 1. Implement basic FUSE interfaces. 2. Implement filesystem trait and relation structures. ### Why are the changes needed? Fix: apache#5734 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
jerryshao
pushed a commit
that referenced
this pull request
Jan 3, 2025
…nd code structure layout (#5835) ### What changes were proposed in this pull request? 1. Implement basic FUSE interfaces. 2. Implement filesystem trait and relation structures. ### Why are the changes needed? Fix: #5734 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jan 4, 2025
…tion and code structure layout (apache#5835) ### What changes were proposed in this pull request? 1. Implement basic FUSE interfaces. 2. Implement filesystem trait and relation structures. ### Why are the changes needed? Fix: apache#5734 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #5734
Does this PR introduce any user-facing change?
No
How was this patch tested?
No