[#6462] fix(filesystem-hadoop3): Fix GVFS client can't find HDFSFileSystemProvider problem
#6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Feb 18, 2025
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.gravitino.catalog.hadoop.fs; |
There was a problem hiding this comment.
Can you rename the package to o.a.g.catalog.hadoop.common for these files?
There was a problem hiding this comment.
I plan to do so before, these changes will bring too many changes to other modules. For instance, changing this package will make all FilesystemProvider implementations scattered in the bundle modules. Another point is that the SPI file is org.apache.gravitino.catalog.hadoop.fs.FileSystemProvider, I'm hesitant to make these changes. Would this be acceptable to you? If so, I will make the necessary changes.
There was a problem hiding this comment.
OK, we can do this in another PR.
jerryshao
approved these changes
Feb 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…SystemProvider` problem (#6463) ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `LocalFileSystemProvider` can't be found. ### Why are the changes needed? It's a bug. Fix: #6462 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs, UTs and test locally.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Feb 19, 2025
…FSFileSystemProvider` problem (apache#6463) ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `LocalFileSystemProvider` can't be found. ### Why are the changes needed? It's a bug. Fix: apache#6462 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs, UTs and test locally.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Feb 19, 2025
…FSFileSystemProvider` problem (apache#6463) ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `LocalFileSystemProvider` can't be found. ### Why are the changes needed? It's a bug. Fix: apache#6462 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs, UTs and test locally.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Mar 2, 2025
…FSFileSystemProvider` problem (apache#6463) ### What changes were proposed in this pull request? In the current code base, we need to add `catalog-hadoop` to make GVFS client works or class `HDFSFileSystemProvider` and `LocalFileSystemProvider` can't be found. ### Why are the changes needed? It's a bug. Fix: apache#6462 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? ITs, UTs and test locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the current code base, we need to add
catalog-hadoopto make GVFS client works or classHDFSFileSystemProviderandLocalFileSystemProvidercan't be found.Why are the changes needed?
It's a bug.
Fix: #6462
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
ITs, UTs and test locally.