Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6233] feat(flink): flink jdbc catalog #6543
base: main
Are you sure you want to change the base?
[#6233] feat(flink): flink jdbc catalog #6543
Changes from 5 commits
55424fc
5a43410
555d014
f24b924
d30d191
a393de9
d8d55d7
f7eee39
7dd5452
86039e4
d529f07
67d731c
9bb4078
deac3d4
0e48086
16713c1
e4fad6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we place the following properties in requiredOptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are already in the flink JdbcCatalogFactory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we should use the requireOptions in
JdbcCatalogFactory
forGravitinoJdbcCatalogFactory
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause these options to be validated twice, both in JdbcCatalogFactory and GravitinoJdbcCatalogFactory. Additionally, since these options are intended for use by JdbcCatalogFactory only, and not needed within GravitinoJdbcCatalogFactory, I think it's unnecessary to add them to the requireOptions method in GravitinoJdbcCatalogFactory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you provide the code path when is's validate in JdbcCatalogFactory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.apache.flink.connector.jdbc.catalog.factory.JdbcCatalogFactory#requiredOptions()

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does flink JDBC connector supports setting JDBC driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is the document about how to create FlinkJdbcCatalog

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems missing the logic about tranforming from
GRAVITINO_JDBC_DRIVER
toFlink_JDBC_DRIVER
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the document seems not the latest, seems Jdbc connector supports setting
driver
https://github.com/apache/flink-connector-jdbc/blob/v3.2/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcConnectorOptions.java#L57-L63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flink jdbc catalog doesn't support setting driver in catalog options but support in table options, the above configuration is for table not catalog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to transform
FLINK_JDBC_DEFAULT_DATABASE
betweenGRAVITINO_JDBC_DEFAULT_DATABASE
, Flink properties converter will do it automaticly.