Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6459][Followup] fix(test): add default sleep for DataItemInList #6567

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

LauraXia123
Copy link
Collaborator

What changes were proposed in this pull request?

Fix ci issue by default sleep

Why are the changes needed?

Need a sleep time for render latest data
Only verifyShowDataItemInList and verifyNoDataItemInList

Fix: #6459

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

repeat run ci test case

@LauraXia123 LauraXia123 self-assigned this Feb 27, 2025
@jerryshao jerryshao changed the title fix(test): add default sleep for DataItemInList [#6459][Followup] fix(test): add default sleep for DataItemInList Feb 27, 2025
@yuqi1129 yuqi1129 closed this Feb 27, 2025
@yuqi1129 yuqi1129 reopened this Feb 27, 2025
@yuqi1129 yuqi1129 closed this Feb 27, 2025
@yuqi1129 yuqi1129 reopened this Feb 27, 2025
@yuqi1129 yuqi1129 closed this Feb 28, 2025
@yuqi1129 yuqi1129 reopened this Feb 28, 2025
@yuqi1129 yuqi1129 closed this Feb 28, 2025
@yuqi1129 yuqi1129 reopened this Feb 28, 2025
@jerryshao
Copy link
Contributor

Let's run for like 10 times to see if this issue still happens.

@yuqi1129 yuqi1129 closed this Feb 28, 2025
@yuqi1129 yuqi1129 reopened this Feb 28, 2025
@yuqi1129 yuqi1129 closed this Feb 28, 2025
@yuqi1129 yuqi1129 reopened this Feb 28, 2025
@LauraXia123 LauraXia123 reopened this Feb 28, 2025
@LauraXia123
Copy link
Collaborator Author

It have run 10 times already, and passed. @jerryshao

@jerryshao
Copy link
Contributor

OK, let me merge to the main branch.

@jerryshao jerryshao merged commit bde2fc8 into apache:main Feb 28, 2025
25 checks passed
Abyss-lord pushed a commit to Abyss-lord/gravitino that referenced this pull request Mar 2, 2025
…st (apache#6567)

### What changes were proposed in this pull request?
Fix ci issue by default sleep

### Why are the changes needed?
Need a sleep time for render latest data
Only verifyShowDataItemInList and verifyNoDataItemInList

Fix: apache#6459 

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
repeat run ci test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep
3 participants