Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6011] fix(authz): MODIFY_TABLE should contain the select table privilege #6620

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

jerqi
Copy link
Contributor

@jerqi jerqi commented Mar 6, 2025

What changes were proposed in this pull request?

MODIFY_TABLE should contain the select table privilege

Why are the changes needed?

More proper semantics

Fix: #6011

Does this PR introduce any user-facing change?

Correct the document.

How was this patch tested?

Modify the UT.

// case 2: Fail to select data from the table
Assertions.assertThrows(
AccessControlException.class, () -> sparkSession.sql(SQL_SELECT_TABLE).collectAsList());
// case 2: Fail select data from the table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change comment. Fail select?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I corrected. You can take a look again.

@jerqi jerqi requested a review from xunliu March 7, 2025 02:27
Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 61cfb52 into apache:main Mar 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] MODIFY_TABLE should contain the privilege to select table
2 participants