-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6636] fix(client): remove py 3.12 classifiers in setup.py #6637
base: main
Are you sure you want to change the base?
[#6636] fix(client): remove py 3.12 classifiers in setup.py #6637
Conversation
How do you know that we don't support Python 3.12? |
I've been trying to install requirements-dev.txt using pip on python 3.12 and I've noticed some errors during the pandas installation. So I did some research and found that pandas has released support for python 3.12 on November 2023, but the version 2.0.3 required by requirements-dev.txt was released on 23 June 2023. Pandas supports py 3.12 from 2.2.0: |
I see, thanks. Gravitino python client alone should work with Python 3.12, I used it locally. Pandas is only used for test/dev, so I think the release package should be worked with 3.12, the dev dependency cannot work with 3.12. Maybe we should make it work with 3.12, what do you think? |
Oh, good point, you are right. I can try playing with the dependencies to see if everything works with python 3.12. However, pandas 2.2 no longer supports python 3.8 (and it's no longer supported by python). So what should we do? |
@AndreVale69 I just check the EOL of Python 3.8, looks like Python 3.8 has already been EOL, so I think we can remove the support of Python 3.8, move on to support 3.12, what do you think? |
Exactly what I was thinking. I'll update the dependencies and check that all the tests work. |
What changes were proposed in this pull request?
Removed
"Programming Language :: Python :: 3.12"
fromsetup.py
classifiers because Gravitino doesn't support Python 3.12 yet.Why are the changes needed?
The setup.py file contains a wrong classifier (python 3.12).
Fix: #6636
Does this PR introduce any user-facing change?
None
How was this patch tested?
Not required.