[#6651] improvement(docker-image): Update docker Hive CI image to 0.1.18 #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengqm
reviewed
Mar 10, 2025
tengqm
reviewed
Mar 12, 2025
docs/docker-image-details.md
Outdated
| @@ -185,6 +185,11 @@ You can use this kind of image to test the catalog of Apache Hive. | |||
|
|
|||
| Changelog | |||
|
|
|||
|
|
|||
| - apache/gravitino-ci:hive-0.1.18 | |||
| - Support UTF-8 encoding for the `hive-site.xml` file and Hive Metastore. For more information, please see [PR](https://github.com/apache/gravitino/pull/6625) | |||
There was a problem hiding this comment.
Suggested change
| - Support UTF-8 encoding for the `hive-site.xml` file and Hive Metastore. For more information, please see [PR](https://github.com/apache/gravitino/pull/6625) | |
| - Support UTF-8 encoding for the `hive-site.xml` file and Hive Metastore. | |
| For more information, please see [PR](https://github.com/apache/gravitino/pull/6625) |
dev/docker/hive/download-release.sh
Outdated
| # limitations under the License. | ||
|
|
||
| # | ||
| # gh-dl-release! It works! |
dev/docker/hive/download-release.sh
Outdated
| # Set all the variables inside the script, make sure you chmod +x it, then | ||
| # to download specific version to my_app.tar.gz: | ||
| # | ||
| # gh-dl-release 2.1.1 my_app.tar.gz |
There was a problem hiding this comment.
- how about make the syntax something like
<script> <package> [release]withreleasedefaults tolatest? - is the
.tar.gznecessary?
I'm thinking something like this:
download-release.sh ranger
download-release.sh ranger 2.4.0
xunliu
reviewed
Mar 12, 2025
There was a problem hiding this comment.
@yuqi1129 Please clean invalid comments.
jerryshao
reviewed
Mar 12, 2025
dev/docker/hive/download-release.sh
Outdated
| VERSION=$1 # tag name or the word "latest" | ||
| GITHUB="https://api.github.com" | ||
|
|
||
| alias errcho='>&2 echo' |
There was a problem hiding this comment.
Not really; it stands for error_echo.
There was a problem hiding this comment.
If it is not used commonly and made by you, I would suggest you pick a better name.
jerryshao
approved these changes
Mar 12, 2025
|
@xunliu do you want to take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
To support more feat. for more please see #6612
Fix: #6651
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing UTs