[#6656 ] fix(trino-connector): support read MySQL time/datetime/timestamp columns with precision #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zacsun <zacsun@lilith.com>
Signed-off-by: zacsun <zacsun@lilith.com>
Signed-off-by: zacsun <zacsun@lilith.com>
diqiu50
reviewed
Mar 11, 2025
...n/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java
Show resolved
Hide resolved
diqiu50
reviewed
Mar 11, 2025
...n/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java
Show resolved
Hide resolved
Signed-off-by: zacsun <zacsun@lilith.com>
diqiu50
reviewed
Mar 13, 2025
| default: | ||
| throw new TrinoException( | ||
| GravitinoErrorCode.GRAVITINO_ILLEGAL_ARGUMENT, | ||
| "Invalid timestamp precision: " + precision + ". Valid values are 0, 3, 6, 9"); |
There was a problem hiding this comment.
There are two problems：
- Is mysql support timestamp(9)?
- The error message should like "Invalid mysql timestamp precision".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix: #6656
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT already added.