[#6079] fix(core): Support model failure event to Gravitino server #6670
+1,123
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support model failure event to Gravitino server.
|
@FANNG1 @jerryshao could you please review this PR when you have time? I’d really appreciate your feedback. |
FANNG1
reviewed
Mar 13, 2025
core/src/main/java/org/apache/gravitino/listener/api/event/DeleteModelFailureEvent.java
Show resolved
Hide resolved
FANNG1
reviewed
Mar 13, 2025
core/src/main/java/org/apache/gravitino/listener/api/event/ModelFailureEvent.java
Outdated
Show resolved
Hide resolved
|
LGTM except minor comments |
add DeveloperApi to failure event class.
|
@FANNG1 @jerryshao I’ve finished updating the code. Please take a look at the PR again when you have time. |
|
LGTM |
FANNG1
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support model failure event to Gravitino server.
Why are the changes needed?
Fix: #6079
Does this PR introduce any user-facing change?
yes, add model failure event to Gravitino server, offering insights into what went wrong and why the operation failed.
How was this patch tested?
local test.