[HUDI-8726] cover USE_TRANSITION_TIME for ckp conversion #12687
+67
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8726
branch
2 times, most recently
from
d904332 to
cbb4e09
Compare
github-actions
bot
added
size:M
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8726
branch
from
cbb4e09 to
398b3e5
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8726
branch
from
398b3e5 to
af123cc
Compare
github-actions
bot
added
size:S
nsivabalan
reviewed
Jan 24, 2025
|
|
||
| public class CheckpointUtils { | ||
|
|
||
| public static final Set<String> DATASOURCES_MUST_USE_CKP_V1 = new HashSet<>(Arrays.asList( | ||
| "org.apache.hudi.utilities.sources.S3EventsHoodieIncrSource", |
There was a problem hiding this comment.
can we do S3EventsHoodieIncrSource.class.getClassName just to ensure we are resilient to moving classes to a diff package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
For checkpoint translation from v1 to v2, if we use USE_TRANSITION_TIME strategy, we should stick to the same checkpoint key
Impact
Covered corner case of checkpoint conversion
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist