[HUDI-8850] Fix record merge mode related issues and improve test coverage in Spark SQL #12725
+448
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-8850-insert-merge-mode
branch
from
44ef790 to
806d7f7
Compare
yihua
force-pushed
the
HUDI-8850-insert-merge-mode
branch
from
806d7f7 to
7d8234d
Compare
github-actions
bot
added
size:L
yihua
force-pushed
the
HUDI-8850-insert-merge-mode
branch
from
7d8234d to
7419a76
Compare
yihua
changed the title
nsivabalan
approved these changes
Jan 30, 2025
4 tasks
linliu-code
pushed a commit
to linliu-code/hudi
that referenced
this pull request
Jan 31, 2025
…erage in Spark SQL (apache#12725) This PR fixes record merge mode issues and improves test coverage in Spark SQL: - Table version 6 lacks record merge mode in the config. The file group reader now infers it if missing, enabling v6 table reads. - For INSERT INTO in Spark SQL, buildHoodieInsertConfig didn't set record merge mode properly. The logic is now removed. - The SQL writer now gets the correct record merge mode from the table config automatically. - In MERGE INTO in Spark SQL, the record merge mode check is fixed to avoid NPE. - More tests are added in TestMergeModeCommitTimeOrdering and TestMergeModeEventTimeOrdering for different merge modes. The tests cover both table version 6 and 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR fixes record merge mode related issues and improves test coverage in Spark SQL:
buildHoodieInsertConfig. The relevant logic is removed since the SQL writer can automatically get the correct write config of record merge mode from the table config.TestMergeModeCommitTimeOrderingandTestMergeModeEventTimeOrderingto coverage different cases of merge modes and both table version 6 and 8.Impact
Bug fixes on record merge mode related issues and improvement on test coverage.
Risk level
low
Documentation Update
N/A
Contributor's checklist