Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8941] Stop spark context with proper exit code in HoodieStreamer #12742

Merged
merged 4 commits into from
Feb 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -640,10 +640,15 @@ public static void main(String[] args) throws Exception {
LOG.warn("--enable-hive-sync will be deprecated in a future release; please use --enable-sync instead for Hive syncing");
}

int exitCode = 0;
try {
new HoodieStreamer(cfg, jssc).sync();
} catch (Exception e) {
LOG.error("Failed to execute HoodieStreamer : {}", e.getMessage());
exitCode = 1;
throw e;
} finally {
jssc.stop();
jssc.sc().stop(exitCode);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. It looks like this API is introduced in Spark 3.4, so it does not compile on Spark 3.3. Could you adapt your change on that?

}
}

Expand Down
Loading