[MINOR] Add validation on hoodie.streamer.source.kafka.minPartitions config and improve logging on kafka offsets #12770
+45
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config and improve logging on kafka offsets
danny0405
reviewed
Feb 5, 2025
| boolean needSplitToMinPartitions = minPartitions > toOffsetMap.size(); | ||
| if (needSplitToMinPartitions && minPartitions % toOffsetMap.size() != 0) { | ||
| throw new IllegalArgumentException("The config " | ||
| + KafkaSourceConfig.KAFKA_SOURCE_MIN_PARTITIONS.key() |
There was a problem hiding this comment.
Can we tweak the value KafkaSourceConfig.KAFKA_SOURCE_MIN_PARTITIONS.key() automatically and log a warning log instead of throwing?
There was a problem hiding this comment.
No longer needed this PR.
yihua
requested changes
Feb 5, 2025
| @@ -124,15 +124,26 @@ public static OffsetRange[] computeOffsetRanges(Map<TopicPartition, Long> fromOf | |||
| Map<TopicPartition, Long> toOffsetMap, | |||
| long numEvents, | |||
| long minPartitions) { | |||
| boolean needSplitToMinPartitions = minPartitions > toOffsetMap.size(); | |||
| if (needSplitToMinPartitions && minPartitions % toOffsetMap.size() != 0) { | |||
There was a problem hiding this comment.
I think this validation is no longer needed as the number of target Kafka partitions does not have to be multiples of the number of input partitions anymore.
There was a problem hiding this comment.
If this is the case, then this upstream is no long needed, since this is the core of this change. I will abandon this PR.
|
This PR is abandoned since it is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Better reliability.
Risk level (write none, low medium or high below)
Low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist