Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8972] Fixing heart beats for failed writes in HoodieStreamer #12802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nsivabalan
Copy link
Contributor

Change Logs

Every commit is expected to release resources irrespective of whether it succeeds or fail. But in HoodieStreamer, in some unhappy paths, we missed to do that. And so, the heart beat could potentially be getting updated for a failed ingestion commit which in turn will never get a chance to rollback by async workers (STS). We are fixing the resource closure ( and hence the heart beat emitting) for failed writes in HoodieStreamer in this patch.

Tests have been written to validate both happy and unhappy paths.

Impact

Robust closure of resources and heart beat stoppage for failed commits in HoodieStreamer.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Feb 6, 2025
@nsivabalan nsivabalan force-pushed the HUDI-8972-heartbeatFix-failed-writes branch from 27676bd to 44d0a9d Compare February 10, 2025 02:56
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M PR with lines of changes in (100, 300]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants