[HUDI-8972] Fixing heart beats for failed writes in HoodieStreamer #12802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Every commit is expected to release resources irrespective of whether it succeeds or fail. But in HoodieStreamer, in some unhappy paths, we missed to do that. And so, the heart beat could potentially be getting updated for a failed ingestion commit which in turn will never get a chance to rollback by async workers (STS). We are fixing the resource closure ( and hence the heart beat emitting) for failed writes in HoodieStreamer in this patch.
Tests have been written to validate both happy and unhappy paths.
Impact
Robust closure of resources and heart beat stoppage for failed commits in HoodieStreamer.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist