Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sbt to 1.10.0 #321

Closed
wants to merge 1 commit into from
Closed

chore: bump sbt to 1.10.0 #321

wants to merge 1 commit into from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented May 29, 2024

Motivation:
Bump sbt to 1.10.0

@He-Pin He-Pin closed this May 29, 2024
@He-Pin He-Pin reopened this May 29, 2024
Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 2 other mentions of 1.9.9 in our source files - this is not the only one

@pjfanning
Copy link
Contributor

I have #322

Updating Scala manually fixed the Scala Steward job. Updating Scala is harder than updating a lib because our CI yml files have Scala versions listed in them. That seems to be the permission that caused us the issue (the permission to update the CI yml files)

@@ -159,7 +159,7 @@ lazy val sbtPlugin = Project(id = "sbt-plugin", base = file("sbt-plugin"))
val p3 = (runtime / publishLocal).value
val p4 = (interopTests / publishLocal).value
},
scriptedSbt := "1.9.9",
scriptedSbt := "1.10.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning the only addition is this line, feel free to anything

@He-Pin He-Pin closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants