Skip to content

Commit

Permalink
Fix tiered store README.md error about Configuration (#7436)
Browse files Browse the repository at this point in the history
* Fix tiered store README.md error about Configuration

* Fix change tieredStoreFilePath to tieredStoreFilepath

* revert README.md change

---------

Co-authored-by: yangguodong.cn <yangguodong.cn@bytedance.com>
  • Loading branch information
golden-yang and yangguodongByteDance authored Nov 9, 2023
1 parent ead3d90 commit 70dc93a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public boolean check(TieredStorageLevel targetLevel) {
private long readAheadCacheExpireDuration = 10 * 1000;
private double readAheadCacheSizeThresholdRate = 0.3;

private String tieredStoreFilePath = "";
private String tieredStoreFilepath = "";

private String objectStoreEndpoint = "";

Expand Down Expand Up @@ -350,12 +350,12 @@ public void setReadAheadCacheSizeThresholdRate(double rate) {
this.readAheadCacheSizeThresholdRate = rate;
}

public String getTieredStoreFilePath() {
return tieredStoreFilePath;
public String getTieredStoreFilepath() {
return tieredStoreFilepath;
}

public void setTieredStoreFilePath(String tieredStoreFilePath) {
this.tieredStoreFilePath = tieredStoreFilePath;
public void setTieredStoreFilepath(String tieredStoreFilepath) {
this.tieredStoreFilepath = tieredStoreFilepath;
}

public void setObjectStoreEndpoint(String objectStoreEndpoint) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ public PosixFileSegment(TieredMessageStoreConfig storeConfig,
super(storeConfig, fileType, filePath, baseOffset);

// basePath
String basePath = StringUtils.defaultString(storeConfig.getTieredStoreFilePath(),
StringUtils.appendIfMissing(storeConfig.getTieredStoreFilePath(), File.separator));
String basePath = StringUtils.defaultString(storeConfig.getTieredStoreFilepath(),
StringUtils.appendIfMissing(storeConfig.getTieredStoreFilepath(), File.separator));

// fullPath: basePath/hash_cluster/broker/topic/queueId/fileType/baseOffset
String brokerClusterName = storeConfig.getBrokerClusterName();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void setUp() throws ClassNotFoundException, NoSuchMethodException {
TieredMessageStoreConfig storeConfig = new TieredMessageStoreConfig();
storeConfig.setBrokerName("brokerName");
storeConfig.setStorePathRootDir(storePath);
storeConfig.setTieredStoreFilePath(storePath + File.separator);
storeConfig.setTieredStoreFilepath(storePath + File.separator);
storeConfig.setTieredBackendServiceProvider("org.apache.rocketmq.tieredstore.provider.posix.PosixFileSegment");
storeConfig.setCommitLogRollingInterval(0);
storeConfig.setTieredStoreCommitLogMaxSize(1000);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class PosixFileSegmentTest {
@Before
public void setUp() {
storeConfig = new TieredMessageStoreConfig();
storeConfig.setTieredStoreFilePath(storePath);
storeConfig.setTieredStoreFilepath(storePath);
mq = new MessageQueue("OSSFileSegmentTest", "broker", 0);
TieredStoreExecutor.init();
}
Expand Down

0 comments on commit 70dc93a

Please sign in to comment.