feat(client): Introduce LOAD_BALANCE mode for partition split #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 005 files - 6 3 005 suites - 6 6h 24m 40s ⏱️ - 15m 44s For more details on these errors, see this check. Results for commit ddd1489. ± Comparison against base commit 31b443e. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the load_balance mode for partition split
Why are the changes needed?
Firstly, thanks the great work to @maobaolong . This work is based on the #2093, this introduces the load_balance mode for the partition split.
As we know, if the partition is big, the partition split will be activated to reassign to another server. For the default impl, the reassign logic is pipeline. it will reassign for first server -> second -> third until reaching the max reassignment server num limit.
But for the huge partition with huge write throughput at the same time, I hope this can write the multi servers for load balance to speed up writing.
Does this PR introduce any user-facing change?
Yes.
rss.client.reassign.partitionSplitMode. Default value PIPELINE (that is consistent with previous codebase)rss.client.reassign.partitionSplitLoadBalanceServerNumber. Default value is 10. Only valid for load balance mode.How was this patch tested?