Add more observability around WS handshake failures #6771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@john-markham: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 0affb52a2746780446dba6f8 |
bnjjj
reviewed
Feb 12, 2025
Comment on lines
676
to
674
| tracing::warn!( | ||
| error.type = "websocket_connection_failed", | ||
| error.details= %error_details, | ||
| error.source = %std::any::type_name_of_val(&err), | ||
| "WebSocket connection failed" | ||
| ); |
There was a problem hiding this comment.
It looks good but I don't think this part is needed as we're returning the SubrequestWsError we should be able to display it using custom telemetry configuration. Also might be worth to add the source to SubrequestWsError
There was a problem hiding this comment.
We can leave adding additional metadata to SubrequestWsError to a followup
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
4 times, most recently
from
c02b6d3 to
c498ae6
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
from
c498ae6 to
9d45f12
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
2 times, most recently
from
35e3083 to
b62176f
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
4 times, most recently
from
2de21a1 to
c561dd4
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
3 times, most recently
from
8be1b17 to
7fd6e95
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
2 times, most recently
from
9f9f20f to
22a7368
Compare
john-markham
force-pushed
the
jm/propose-utf-8-observability
branch
from
22a7368 to
d8c40ab
Compare
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
6 tasks
|
Thanks @john-markham closing this PR in favor of #6798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description here
Fixes #issue_number
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩