Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with aporeto iptables we do not need to check for ip6tables #960

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0xmchadha
Copy link
Contributor

Description

Changes proposed in this pull request.

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

@0xmchadha
Copy link
Contributor Author

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "26f53935ea7630a37871ffabecbaab7d227a5ba1",
    "pipeline": "master"
  }
]

@0xmchadha
Copy link
Contributor Author

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "472f8732d41ca2526a660ff8dc0012713f33f3fb",
    "pipeline": "master"
  }
]

@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #960 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   54.36%   54.37%   +<.01%     
==========================================
  Files         123      123              
  Lines       11814    11816       +2     
==========================================
+ Hits         6423     6425       +2     
  Misses       4764     4764              
  Partials      627      627
Impacted Files Coverage Δ
utils/crypto/crypto.go 78.37% <100%> (ø) ⬆️
...ontroller/internal/supervisor/iptablesctrl/ipv6.go 96.29% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26f5393...f8de4e5. Read the comment docs.

@0xmchadha
Copy link
Contributor Author

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1569",
    "commit-sha": "dbfcccd23c2b3b48c7369f18298f9c832e0cd91e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "960",
    "commit-sha": "f8de4e5d3f75cf0d842483d97cbec60496d673aa",
    "pipeline": "master"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant