Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brianonn pr968 nodebug nobypass #969

Draft
wants to merge 3 commits into
base: release-3.13.0
Choose a base branch
from

Conversation

brianonn
Copy link
Contributor

removed debug statements from PR 968

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #969 into release-3.13.0 will increase coverage by 0.48%.
The diff coverage is 14.28%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.13.0     #969      +/-   ##
==================================================
+ Coverage           56.51%   56.99%   +0.48%     
==================================================
  Files                 111      111              
  Lines               11250    11951     +701     
==================================================
+ Hits                 6358     6812     +454     
- Misses               4284     4482     +198     
- Partials              608      657      +49
Impacted Files Coverage Δ
...oller/internal/supervisor/iptablesctrl/iptables.go 56.11% <0%> (-0.48%) ⬇️
controller/pkg/aclprovider/iptablesprovider.go 48.35% <20%> (-0.22%) ⬇️
controller/pkg/packet/packet.go 49.7% <0%> (-2.24%) ⬇️
...ller/internal/enforcer/nfqdatapath/datapath_udp.go 0% <0%> (ø) ⬆️
...roller/internal/enforcer/nfqdatapath/test_utils.go 75% <0%> (ø) ⬆️
controller/pkg/tokens/jwt.go 85.62% <0%> (+2.9%) ⬆️
controller/pkg/tokens/binaryjwt.go 63.73% <0%> (+3.02%) ⬆️
...ller/internal/enforcer/nfqdatapath/datapath_tcp.go 62.6% <0%> (+3.05%) ⬆️
...ntroller/internal/enforcer/nfqdatapath/datapath.go 69.13% <0%> (+5.67%) ⬆️
controller/internal/enforcer/nfqdatapath/utils.go 85.41% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084ff24...83aeb5c. Read the comment docs.

@brianonn
Copy link
Contributor Author

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1573",
    "commit-sha": "dacb828bec8ce40e41f6293b27376d0d5f811291",
    "pipeline": "release-3.13.0"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "969",
    "commit-sha": "83aeb5c71593d9b35e5067e59e745c756a6a597e",
    "pipeline": "release-3.13.0"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant