New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nfqueuebalance #987

Open

amitlimaye wants to merge 23 commits into master from nfqueuebalance

Contributor

amitlimaye commented Mar 12, 2020

Description

Changes proposed in this pull request.
move from nfqueuebalance to our own hash for loadblancing

Test plan

Outline the test plan used to test this change before merging it.

Fixes #.

Amit Limaye added 6 commits

March 5, 2020 14:03


          Fix Docker monitor to use the default newcgroupnetcontroller

36b5969


          Add lock to newcgroupcontroller to serialize mount across different m…

bea8036

…onitors


          Add an indexallocator

7ff95de


          add unit test

1e2161f


          cleanup of indexAllocator

05bc357


          Chnages for nfqueuebalance

a70b482

amitlimaye requested review from satyamsi and dstiliadis

March 12, 2020 19:10

dstiliadis reviewed

View reviewed changes

utils/cgnetcls/internal/indexallocator/indexallocator.go Show resolved Hide resolved

Amit Limaye added 11 commits

March 12, 2020 14:07


          Unit test fixes

c2612b9


          Fixed Unit tests

c1efb1f


          Unit test for v6

4450a79


          Merge branch 'master' of github.com:aporeto-inc/trireme-lib into nfqu…

bc6817e

…euebalance


          Fix unit test

57cc39f


          Unit test fixes

d0fb786


          Unit test fixes and general code cleanup

38e572a


          moving random to constants

1dae872


          Fix extractor tests

36d216e


          linter fixes

9e0e301


          comment unit test because parallel goroutines

56bf72b

codecov bot commented Mar 13, 2020 •

edited

Loading

Codecov Report

Merging #987 into master will increase coverage by 0.49%.
The diff coverage is 67.97%.

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   54.83%   55.32%   +0.49%     
==========================================
  Files         124      125       +1     
  Lines       11982    12137     +155     
==========================================
+ Hits         6570     6715     +145     
+ Misses       4784     4782       -2     
- Partials      628      640      +12

Impacted Files	Coverage Δ
utils/cgnetcls/netcls.go	`0% <0%> (ø)`	⬆️
...ntroller/internal/enforcer/nfqdatapath/datapath.go	`57.58% <100%> (+0.44%)`	⬆️
...ller/internal/supervisor/iptablesctrl/templates.go	`86.42% <100%> (+0.71%)`	⬆️
...ontroller/internal/supervisor/iptablesctrl/acls.go	`68.91% <100%> (+0.51%)`	⬆️
monitor/internal/docker/config.go	`100% <100%> (ø)`	⬆️
...oller/internal/supervisor/iptablesctrl/iptables.go	`55.73% <100%> (+0.36%)`	⬆️
...cgnetcls/internal/indexallocator/indexallocator.go	`100% <100%> (ø)`
utils/cgnetcls/cgnetcls.go	`15.95% <20%> (+0.81%)`	⬆️
monitor/internal/docker/monitor.go	`47.01% <44.44%> (-0.52%)`	⬇️
monitor/extractors/linux.go	`48.88% <60%> (+0.1%)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2781aef...11ab284. Read the comment docs.

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "3ec7e679108f8483f4bbb3348e121e27580a3d92",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "56bf72b35c91fe24bccf6605ff3490ea68306bcc",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "62025d5683f949324e769536a4c4a46d2462a87d",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "56bf72b35c91fe24bccf6605ff3490ea68306bcc",
    "pipeline": "master"
  }
]


          make windows happy

17bfef2

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "62025d5683f949324e769536a4c4a46d2462a87d",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "b2c52ea561c8fdb8e2faae111c1ed7c4d35c684f",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "8dbc76734b26cf552f0c840df0c1d08ea964e7c3",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "5f4bf0f28cee798f1956592a096f7c69278f4291",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "bc9c514d2d8d96ef35ed8b1c7200ef2b7803b3e0",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "17bfef2c0c932c4630eded22937de05345a3a32e",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "2f64c5b9edd830ea7bb812e60db8ae76a543e98b",
    "pipeline": "master"
  }
]


          Fix uidpam rules

0cbfa3c

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "2f64c5b9edd830ea7bb812e60db8ae76a543e98b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "0cbfa3c5214f7e6794d719e5393e7ac39d3b73f9",
    "pipeline": "master"
  }
]

1 similar comment

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "2f64c5b9edd830ea7bb812e60db8ae76a543e98b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "0cbfa3c5214f7e6794d719e5393e7ac39d3b73f9",
    "pipeline": "master"
  }
]


          Fix Typo

066abd0

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "2f64c5b9edd830ea7bb812e60db8ae76a543e98b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "066abd0e95d234afbad9be596929480c2339f570",
    "pipeline": "master"
  }
]


          Fixing windows rules

053e453

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "2f64c5b9edd830ea7bb812e60db8ae76a543e98b",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "053e453954c679403c30198285144949639569e8",
    "pipeline": "master"
  }
]


          Remove the ebpf debug message

6c25900

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "9f2d920a21c106c3c7e9ef74f19be7124c3228ef",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "6c2590020ac951efee4a0d44f48270e3f8418529",
    "pipeline": "master"
  }
]


          Reset InitialMarkVal to 100 again

11ab284

Collaborator

aporeto-bot commented Mar 13, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "f422a2f492c1838e325ce2d75fff5d4cdbdf16a5",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "11ab284574630189c2f7504da462e2097183f09f",
    "pipeline": "master"
  }
]

Collaborator

aporeto-bot commented Mar 16, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "b2eae825a06ea7c3c5a8cfc076f4a3e27fbab70f",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "11ab284574630189c2f7504da462e2097183f09f",
    "pipeline": "master"
  }
]

1 similar comment

Collaborator

aporeto-bot commented Mar 16, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1608",
    "commit-sha": "b2eae825a06ea7c3c5a8cfc076f4a3e27fbab70f",
    "pipeline": "master"
  },
  {
    "project": "",
    "component": "trireme-lib",
    "pr-id": "987",
    "commit-sha": "11ab284574630189c2f7504da462e2097183f09f",
    "pipeline": "master"
  }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet