refactor(signal): refactor signal handling across platforms #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor signal handling in `manager.go` to use a slice of signals instead of individual signal constants. - Remove handling of `SIGTSTP` signal and associated logging in `manager.go`. - Update signal sending in tests within `manager_test.go` to use `os.FindProcess` and `process.Signal` instead of `syscall.Kill`. - Add `os` package import in `manager_test.go`. - Create new file `signals_unix.go` with a slice of signals for Unix-based systems including `SIGINT`, `SIGTERM`, and `SIGTSTP`. - Create new file `signals_windows.go` with a slice of signals for Windows systems including `SIGINT` and `SIGTERM`. Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manager.goto use a slice of signals instead of individual signal constants.SIGTSTPsignal and associated logging inmanager.go.manager_test.goto useos.FindProcessandprocess.Signalinstead ofsyscall.Kill.ospackage import inmanager_test.go.signals_unix.gowith a slice of signals for Unix-based systems includingSIGINT,SIGTERM, andSIGTSTP.signals_windows.gowith a slice of signals for Windows systems includingSIGINTandSIGTERM.