Skip to content

Generate and test .deb package for Debian and Ubuntu #2

Generate and test .deb package for Debian and Ubuntu

Generate and test .deb package for Debian and Ubuntu #2

GitHub Actions / clippy succeeded Dec 14, 2024 in 1s

clippy

49 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 49
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 223 in rp/src/exchange.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression borrows a value the compiler would automatically borrow

warning: this expression borrows a value the compiler would automatically borrow
   --> rp/src/exchange.rs:223:34
    |
223 |     let final_cleanup_handlers = (&cleanup_handlers).clone();
    |                                  ^^^^^^^^^^^^^^^^^^^ help: change this to: `cleanup_handlers`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 171 in rp/src/exchange.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> rp/src/exchange.rs:171:5
    |
171 |     Arc<::futures::lock::Mutex<Vec<Pin<Box<dyn Future<Output = Result<(), Error>> + Send>>>>>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 1053 in rosenpass/src/protocol/protocol.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
    --> rosenpass/src/protocol/protocol.rs:1052:5
     |
1052 | /     /// Bails on messages sent by responder and non-handshake messages.
1053 | |
     | |_
1054 | /     pub fn handle_msg_under_load<H: HostIdentification>(
1055 | |         &mut self,
1056 | |         rx_buf: &[u8],
1057 | |         tx_buf: &mut [u8],
1058 | |         host_identification: &H,
1059 | |     ) -> Result<HandleMsgResult> {
     | |________________________________- the comment documents this method
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
     = help: if the empty line is unintentional remove it

Check warning on line 12 in rosenpass/src/msgs.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
  --> rosenpass/src/msgs.rs:12:5
   |
12 | use std::u8;
   |     ^^^^^^^
   |
   = help: remove this import
   = note: then `u8::<CONST>` will resolve to the respective associated constant
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default

Check warning on line 40 in ciphers/src/hash_domain.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty line after doc comment

warning: empty line after doc comment
  --> ciphers/src/hash_domain.rs:39:1
   |
39 | / ///
40 | |
   | |_
...
46 |   pub struct HashDomain([u8; KEY_LEN]);
   |   --------------------- the comment documents this struct
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
   = help: if the empty line is unintentional remove it
help: if the doc comment should not document `HashDomain` comment it out
   |
9  ~ // ///
10 ~ // ///```rust
11 ~ // /// # use rosenpass_ciphers::hash_domain::{HashDomain, HashDomainNamespace, SecretHashDomain, SecretHashDomainNamespace};
12 ~ // /// use rosenpass_secret_memory::Secret;
13 ~ // /// # rosenpass_secret_memory::secret_policy_use_only_malloc_secrets();
14 ~ // ///
15 ~ // /// const PROTOCOL_IDENTIFIER: &str = "MY_PROTOCOL:IDENTIFIER";
16 ~ // /// # fn do_doc_test() -> Result<(), Box<dyn std::error::Error>> {
17 ~ // /// // create use once hash domain for the protocol identifier
18 ~ // /// let mut hash_domain = HashDomain::zero();
19 ~ // /// hash_domain = hash_domain.mix(PROTOCOL_IDENTIFIER.as_bytes())?;
20 ~ // /// // upgrade to reusable hash domain
21 ~ // /// let hash_domain_namespace: HashDomainNamespace = hash_domain.dup();
22 ~ // /// // derive new key
23 ~ // /// let key_identifier = "my_key_identifier";
24 ~ // /// let key = hash_domain_namespace.mix(key_identifier.as_bytes())?.into_value();
25 ~ // /// // derive a new key based on a secret
26 ~ // /// const MY_SECRET_LEN: usize = 21;
27 ~ // /// let my_secret_bytes = "my super duper secret".as_bytes();
28 ~ // /// let my_secret: Secret<21> = Secret::from_slice("my super duper secret".as_bytes());
29 ~ // /// let secret_hash_domain: SecretHashDomain = hash_domain_namespace.mix_secret(my_secret)?;
30 ~ // /// // derive a new key based on the secret key
31 ~ // /// let new_key_identifier = "my_new_key_identifier".as_bytes();
32 ~ // /// let new_key = secret_hash_domain.mix(new_key_identifier)?.into_secret();
33 ~ // ///
34 ~ // /// # Ok(())
35 ~ // /// # }
36 ~ // /// # do_doc_test().unwrap();
37 ~ // ///
38 ~ // ///```
39 ~ // ///
   |

Check warning on line 1 in util/src/zeroize/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> util/src/zeroize/mod.rs:1:1
  |
1 | mod zeroized_ext;
  | ^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 3 in util/src/zerocopy/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> util/src/zerocopy/mod.rs:3:1
  |
3 | mod zerocopy_slice_ext;
  | ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 2 in util/src/zerocopy/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> util/src/zerocopy/mod.rs:2:1
  |
2 | mod zerocopy_ref_ext;
  | ^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 14 in util/src/zerocopy/ref_maker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> util/src/zerocopy/ref_maker.rs:14:5
   |
14 |     _phantom_t: PhantomData<T>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 13 in util/src/zerocopy/ref_maker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> util/src/zerocopy/ref_maker.rs:13:5
   |
13 |     buf: B,
   |     ^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 1 in util/src/zerocopy/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
 --> util/src/zerocopy/mod.rs:1:1
  |
1 | mod ref_maker;
  | ^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 276 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a macro

warning: missing documentation for a macro
   --> util/src/typenum.rs:165:5
    |
165 | /     macro_rules! test_const_conversion {
166 | |         // Type groups
167 | |
168 | |         (($($typenum:ty),*) >= u7 = $const:expr $(; $($rest:tt)*)?) => {
...   |
275 | |         };
276 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 350 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
   --> util/src/typenum.rs:160:1
    |
160 | / mod test {
161 | |     use static_assertions::const_assert_eq;
162 | |     use typenum::consts::*;
163 | |     use typenum::op;
...   |
349 | |     }
350 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 121 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a macro

warning: missing documentation for a macro
   --> util/src/typenum.rs:94:1
    |
94  | / macro_rules! impl_numeric_into_const_signed {
95  | |     ($($to_list:ty : $unsigned_list:ty),*) =>  {
96  | |         $( impl_numeric_into_const_signed! { @impl $to_list : $unsigned_list} )*
97  | |     };
...   |
120 | |     };
121 | | }
    | |_^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 92 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a macro

warning: missing documentation for a macro
  --> util/src/typenum.rs:76:1
   |
76 | / macro_rules! impl_numeric_into_const_unsigned {
77 | |     ($($to_list:ty),*) =>  {
78 | |         $( impl_numeric_into_const_unsigned! { @impl $to_list } )*
79 | |     };
...  |
91 | |     };
92 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 74 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a macro

warning: missing documentation for a macro
  --> util/src/typenum.rs:54:1
   |
54 | / macro_rules! impl_numeric_into_const_common {
55 | |     ($type:ty) => {
56 | |         impl_into_const! { Z0 as $type := 0 }
57 | |         impl_into_const! { B0 as $type := 0 }
...  |
73 | |     };
74 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 52 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a macro

warning: missing documentation for a macro
  --> util/src/typenum.rs:46:1
   |
46 | / macro_rules! impl_into_const {
47 | |     ( $from:ty as $to:ty := $impl:expr) => {
48 | |         impl IntoConst<$to> for $from {
49 | |             const VALUE: $to = $impl;
50 | |         }
51 | |     };
52 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 43 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an associated type

warning: missing documentation for an associated type
  --> util/src/typenum.rs:43:5
   |
43 |     type Type;
   |     ^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 39 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> util/src/typenum.rs:39:1
   |
39 | struct ConstAdd<T, Lhs: IntoConst<T>, Rhs: IntoConst<T>>(*const T, *const Lhs, *const Rhs); // impl IntoConst<T>
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 36 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> util/src/typenum.rs:36:1
   |
36 | struct ConstLshift<T, Param: IntoConst<T>, const SHIFT: i32>(*const T, *const Param); // impl IntoConst<T>
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 33 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> util/src/typenum.rs:30:1
   |
30 | / struct ConstApplyPosSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>(
31 | |     *const T,
32 | |     *const Param,
33 | | );
   | |__^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 27 in util/src/typenum.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> util/src/typenum.rs:24:1
   |
24 | / struct ConstApplyNegSign<T: AssociatedUnsigned, Param: IntoConst<<T as AssociatedUnsigned>::Type>>(
25 | |     *const T,
26 | |     *const Param,
27 | | );
   | |__^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 23 in util/src/mio/uds_recv_fd.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> util/src/mio/uds_recv_fd.rs:23:5
   |
23 |     _sock_dummy: PhantomData<Sock>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 22 in util/src/mio/uds_recv_fd.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> util/src/mio/uds_recv_fd.rs:22:5
   |
22 |     fds: BorrowFds,
   |     ^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items

Check warning on line 21 in util/src/mio/uds_recv_fd.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
  --> util/src/mio/uds_recv_fd.rs:21:5
   |
21 |     socket: BorrowSock,
   |     ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items