Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: require input field of Rego metadata #330

Merged
merged 1 commit into from
Jan 30, 2025
Merged

lint: require input field of Rego metadata #330

merged 1 commit into from
Jan 30, 2025

Conversation

nikpivkin
Copy link
Contributor

Checks that do not use the input field are applied to all input data:

2025-01-30T02:59:21.0158634Z 2025-01-30T02:55:18Z	WARN	[rego] Module has no input selectors - it will be loaded for all inputs!	file_path="checks/kubernetes/gatekeeper/repo_ambiguous_prefix.rego" module="checks/kubernetes/gatekeeper/repo_ambiguous_prefix.rego"

@nikpivkin nikpivkin requested a review from simar7 as a code owner January 30, 2025 04:29
@nikpivkin
lint: require input field of Rego metadata
24ca79c 
Signed-off-by: Nikita Pivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin mentioned this pull request Jan 30, 2025
Merged
6 tasks
simar7
simar7 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simar7 simar7 added this pull request to the merge queue Jan 30, 2025
Merged via the queue into aquasecurity:main with commit a1719ee Jan 30, 2025
6 checks passed
@nikpivkin nikpivkin deleted the lint/meta-input branch January 30, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7