Skip to content

Commit

Permalink
Fix linting (#787)
Browse files Browse the repository at this point in the history
  • Loading branch information
sohkai authored May 16, 2019
1 parent 476b87d commit e08deb6
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 6 deletions.
9 changes: 8 additions & 1 deletion src/components/App/AppLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,14 @@ function useLoadingStatus({
const progress = stepIndex / (loadingSteps.steps.length - 1)

setStatus({ label, progress })
}, [appLoading, appsLoading, daoLoading, loadingSteps, currentAppName])
}, [
appLoading,
appsLoading,
daoLoading,
loadingSteps,
currentAppName,
instanceId,
])

return { label, progress }
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/LoadingScreen/LoadingScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const LoadingScreen = React.memo(function LoadingScreen({
setVisible(true)
}
return () => clearTimeout(timer)
}, [progress])
}, [progress, visible])

return (
<Transition
Expand Down
11 changes: 8 additions & 3 deletions src/components/LocalIdentityModal/LocalIdentityModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { ModalContext } from '../ModalManager/ModalManager'
import EscapeOutside from '../EscapeOutside/EscapeOutside'
import IdentityBadgeWithNetwork from '../IdentityBadge/IdentityBadgeWithNetwork'
import keycodes from '../../keycodes'
import { EthereumAddressType } from '../../prop-types'

const LocalIdentityModal = React.memo(
({ opened, address, label, onCancel, onSave }) => {
Expand All @@ -30,6 +31,10 @@ const LocalIdentityModal = React.memo(

LocalIdentityModal.propTypes = {
opened: PropTypes.bool.isRequired,
address: EthereumAddressType,
label: PropTypes.string,
onCancel: PropTypes.func.isRequired,
onSave: PropTypes.func.isRequired,
}

const Modal = ({ address, label, onCancel, onSave }) => {
Expand Down Expand Up @@ -104,10 +109,10 @@ const Modal = ({ address, label, onCancel, onSave }) => {
}

Modal.propTypes = {
address: PropTypes.string,
address: EthereumAddressType,
label: PropTypes.string,
onCancel: PropTypes.func,
onSave: PropTypes.func,
onCancel: PropTypes.func.isRequired,
onSave: PropTypes.func.isRequired,
}

const Error = styled.div`
Expand Down
9 changes: 8 additions & 1 deletion src/hooks.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { useCallback, useEffect, useMemo, useReducer, useState, useRef } from 'react'
import {
useCallback,
useEffect,
useMemo,
useReducer,
useState,
useRef,
} from 'react'
import keycodes from './keycodes'
import { log, removeStartingSlash } from './utils'
import { atou } from './string-utils'
Expand Down

0 comments on commit e08deb6

Please sign in to comment.