GA-149 | MultiGraph Support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failing for now
no new tests yet, just experimenting with `AdjListInnerDict`
still no new tests, just brainstorming
starting to get messy...
Attribute used to establish if all ArangoDB IDs have been retrieved for the particular dict class. Not to be confused with `FETCHED_ALL_DATA`, which fetches both IDs & Documents
minimal suite for now. need to revisit
hkernbach
reviewed
Aug 12, 2024
hkernbach
reviewed
Aug 12, 2024
hkernbach
reviewed
Aug 12, 2024
|
|
||
| def __process_int_edge_key(self, key: int) -> str: | ||
| if key < 0: | ||
| key = len(self.data) + key |
There was a problem hiding this comment.
What about keys that could land in the range before self.data + key? Can keys be set manually? In case yes, we need to make sure that we do not use an existing key by accident.
There was a problem hiding this comment.
Good question - this particular strategy is only used for reading Edges that have already been loaded into the local dict object (i.e G[1][2]). Setting keys as integers is currently not possible, so we should be in the clear here
hkernbach
reviewed
Aug 12, 2024
aMahanna
changed the title
this will be useful for bulk updates
Just a temporary solution. Will be removed shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.