-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nx.Graph
CRUD Interface
#3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last push before CI starts failing...
will revisit later
node removal was bugged
need to revisit eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces 6 new
UserDict
-based classes:GraphDict
-->g.graph
NodeDict
-->g._node
NodeAttrDict
-->g._node['node/1']
AdjListOuterDict
-->g._adj
AdjListInnerDict
-->g._adj['node/1']
EdgeAttrDict
-->g._adj['node/1']['node/2']
Each class needs to maintain a responsibility to honor CRUD operations against the DB, all while maintaining the exact same behaviour as the
graph
,_node
, and_adj
objects fromnx.Graph
Also adds:
shortest_path
as a server-side algorithm (the firstnxadb
"custom" algorithm)query()
method wrapper (nothing fancy for now)TODO:
DiGraph
implementation?There are currently 4 ways to run algorithms with
nxadb
:(GPU) Load the entire Graph into memory as
nxcg.Graph
(CPU) Load the entire Graph into memory as
nx.Graph
(CPU) Load certain parts of the Graph into memory by relying on the underlying
UserDict
-based dictionaries to "fetch" the data required from ArangoDB. This could imply that the graph may not need to be fully loaded into memory. For example,nx.all_neighbors
. The structure remains as anxadb.Graph
.(N/A) Don't load the Graph at all. Instead, rely on the ArangoDB implementation of Algorithm X. For example,
nx.shortest_path
. The structure remains as anxadb.Graph
.