Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the return type of AccessValues::size() to be view-like #1206

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jan 28, 2025

This also fixes a recently introduced warning (#1180).

Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Views use size_t regardless of the backend.
(Just picking on the PR title)

@dalg24
Copy link
Contributor

dalg24 commented Jan 29, 2025

This also fixes a recently introduced warning.

Please paste the warning you are referring to.
It's unclear that the changes proposed are the right thing to do with the information provided so far.

@aprokop
Copy link
Contributor Author

aprokop commented Jan 29, 2025

Please paste the warning you are referring to.

In ArborX_SpaceFillingCurves.hpp:75:

comparison of integers of different signs:
'size_t' (aka 'unsigned long') and 'typename View *, Device>::size_type' (aka 'int')
[-Wsign-compare]
ARBORX_ASSERT(linear_ordering_indices.size() == values.size()); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~

This also fixes a recently introduced warning.
@aprokop aprokop merged commit 2bf01bf into arborx:master Jan 30, 2025
2 checks passed
@aprokop aprokop deleted the fix_warning branch January 30, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants