Remove cppc from the zen5 feature list
#131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivations for taking `cppc` out: * There's no upstream support in KVM for this AMD feature, so this won't be trivial to support for KVM-based virtualization. Plus AFAIK this feature isn't used in Linux yet. * This does not seem to be something a compiler would use. For instance this is not included in GCC's znver5 list: https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html. * There are other existing features that can tell zen5 apart from previous zen generations, for instance `avx_vnni` and `movdiri`, so the removal won't impact correct identification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations for taking
cppcout:There's no upstream support in KVM for this AMD feature, so this won't be trivial to support for KVM-based virtualization. Plus AFAIK this feature isn't used in Linux yet.
This does not seem to be something a compiler would use. For instance this is not included in GCC's znver5 list: https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html.
There are other existing features that can tell zen5 apart from previous zen generations, for instance
avx_vnniandmovdiri, so the removal won't impact correct identification.